-
Notifications
You must be signed in to change notification settings - Fork 1
UCS Redux - Lynx Boreal (GSI-1685) #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for putting this together! Here are my thoughts:
@Cito Can you maybe chip in some thoughts on the auth aspects? |
|
@lkuchenb My thoughts: This is very similar to what we do with the work package service for downloads, and in fact the work package schema already allows a work package type of "upload" which would be pretty much the same as an UploadContext. I think it would be good to align the terminology and methods and use it for both upload and download. The only problem is that currently work packages are based on datasets, but we can always create a complete dataset for the study. We can then also reuse the auth mechanism for work packages, i.e. long-lived work package access tokens and short-lived work order tokens for individual files. |
Cito
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added my two cents.
Cito
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, it's much clearer now.
Unfortunately, we still have some muddy parts that need clarification, see comments.
Cito
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added a few suggestions again.
In addition to these, the epic also needs to be adapted to reflect the decision to split the UploadContext into two different domain objects: a DataUploadBox in the core domain, and a FileUploadBundle in the file domain. There is a 1:1 relationship between these, and to keep it simple they could share the same ID value.
The FileUploadBundle would live in the UCS just have the ID and an open/closed state, plus aggregated file count and size for all the files in the bundle (this is redundant since it can be calculated from the FileUpload objects).
The DataUploadBox would live in the UOS also have a title, a locked state, the sane aggregated data, maybe some more fields like "last changed" and "last changed by".
The DataUploadBox should also be replicated to the WPS (at least the title, state, and aggregated data). The user can then fetch all the necessary data to create a work package from the same WPS service, instead of needing to communicate with WPS and UOS. We do something similar with the dataset for download.
Cito
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this is really very good already. Made a few suggestions and corrections, but nothing groundbreaking.
Co-authored-by: Christoph Zwerschke <[email protected]>
Co-authored-by: Leon Kuchenbecker <[email protected]>
Co-authored-by: Leon Kuchenbecker <[email protected]>
Co-authored-by: Leon Kuchenbecker <[email protected]>
74b59b9 to
9f85348
Compare
…d mention fileuploadreport events
No description provided.